Fail fast and more helpfully on invalid compile
argument
#655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument of
compile
can cause a variety of interesting misbehaviors later on if it's anything other than a single path component.compile("foo/bar")
fails with:error: ar: /path/to/target/debug/build/repro-2641eaae14bc95dd/out/libfoo/bar.a: No such file or directory
compile("")
fails with:error: empty library name given via `-l`
compile("/tmp")
fails with:error: ar: /git/cxx/target/debug/build/demo-2641eaae14bc95dd/out/lib/tmp.a: No such file or directory
All of these are probably different from what the user had in mind. This PR adds an assertion that the
compile
argument consists of a single "normal" path component i.e. not containing path separators or anything else probably wrong. Choosing an argument forcompile
is already confusing for people because it can pretty much be arbitrary, but the intent is that it's supposed to be an arbitrary single path component.