Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More lowering improvements #606

Merged
merged 10 commits into from
Sep 11, 2020
Merged

More lowering improvements #606

merged 10 commits into from
Sep 11, 2020

Conversation

detrumi
Copy link
Member

@detrumi detrumi commented Sep 8, 2020

No description provided.

@detrumi detrumi marked this pull request as ready for review September 8, 2020 21:03
jackh726
jackh726 requested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but r=me after.

chalk-integration/src/lowering/program_lowerer.rs Outdated Show resolved Hide resolved
chalk-integration/src/lowering/program_lowerer.rs Outdated Show resolved Hide resolved
chalk-integration/src/lowering.rs Show resolved Hide resolved
chalk-integration/src/lowering.rs Outdated Show resolved Hide resolved
chalk-integration/src/lowering/env.rs Outdated Show resolved Hide resolved
jackh726
jackh726 approved these changes Sep 11, 2020
View reviewed changes
chalk-integration/src/lowering/env.rs
pub addl_variable_kinds: Vec<chalk_ir::VariableKind<ChalkIr>>,
}

pub enum TypeLookup<'k> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue this isn't quite TypeLookup since Trait isn't a type, but eh. This is probably fine.

@detrumi detrumi merged commit 42f24b8 into rust-lang:master Sep 11, 2020
@detrumi detrumi deleted the lowering-improvements branch September 11, 2020 17:28
@bors bors mentioned this pull request Sep 11, 2020
Closed
@jackh726
Copy link
Member

@detrumi please r=jackh726 instead of merging directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@detrumi @jackh726