Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Visitor::BreakTy #651

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Conversation

LeSeulArtichaut
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut commented Nov 7, 2020

Implements the equivalent of MCP rust-lang/compiler-team#383 in chalk.
r? @jackh726

Should probably be blocked on rust-lang/compiler-team#383.

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Gonna hold off on merging until rustc side is merged. But once that happens, anyone should feel free to merge.

@LeSeulArtichaut
Copy link
Contributor Author

Status: rust-lang/compiler-team#383 should finish its FCP in two hours and rust-lang/rust#78779 was just r+ed (early)

@jackh726
Copy link
Member

Works for me!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2020

📌 Commit 905c72d has been approved by jackh726

@bors
Copy link
Contributor

bors commented Nov 15, 2020

⌛ Testing commit 905c72d with merge bc99ed6...

@bors
Copy link
Contributor

bors commented Nov 15, 2020

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing bc99ed6 to master...

@bors bors merged commit bc99ed6 into rust-lang:master Nov 15, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the visitor-breakty branch November 15, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants