Disable some targets where zlib-ng seems to no longer compile with default flags #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
changed the title
thomcc
force-pushed
the
disable-failing-ci
branch
from
00036cb to
70fc898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zlib-ngseems to need some extra flags to work on armv7 (to enable neon) or ppc64 (to enable altivec), so it's not really a great test case. I'll look into a better fix this weekend, but for now I'd prefer to just disable these, since the failures are effectively spurious.I think a nice fix in the future might be if we passed along the flags needed based on CARGO_CFG_TARGET_FEATURES? I haven't thought about this much, so perhaps this is out of place for cmake-rs.
See also #80, where this was added. For whatever reason, that PR didn't have the same issues (older version of zlib-ng?)