Implement i128 <-> float conversion functions #161
Conversation
|
Okay, I've implemented tests locally, will push once this is merged japaric/cast.rs#13 and a new version of cast.rs is pushed to crates.io |
|
Awesome, @est31. Thanks! @homunkulus r+ |
|
Okay, with this PR applied, everything should work now: japaric/cast.rs#14 |
|
re-r? @japaric |
|
@homunkulus r+ |
|
whoops, wrong bot @bors r+ |
|
📌 Commit e574d8b has been approved by |
Implement i128 <-> float conversion functions
Implements {u,i}128 <-> float conversion functions.
|
💔 Test failed - status-appveyor |
est31
force-pushed
the
i128
branch
2 times, most recently
from
2abbc3c
to
667b97d
Compare
Its possible that the generated f64 is different from the expected one by one bit. This is legal when both values are equally close to the i128/u128.
Previously, the tests failed on some platforms due to it.
|
re-r? @japaric |
|
@bors r+ |
|
📌 Commit 673a6f9 has been approved by |
Implement i128 <-> float conversion functions
Implements {u,i}128 <-> float conversion functions.
|
💔 Test failed - status-travis |
|
About the thumb failure, I'm not sure whether I'm the cause of it, or whether its a spurious issue. About the mips failure, I can reproduce it locally. Will investigate tomorrow. |
|
Note that the mips failure is spurious, as sometimes I can reproduce, sometimes I can't (for every try i delete the target/ dir). As for the thumb failure, I have tried to reproduce it but got failures earlier on (sth like |
|
@homunkulus r+ |
|
@bors r+ |
|
📌 Commit 258fead has been approved by |
Implement i128 <-> float conversion functions
Implements {u,i}128 <-> float conversion functions.
|
☀️ Test successful - status-appveyor, status-travis |
Implements {u,i}128 <-> float conversion functions.