Fix CI for thumb* targets #232
Conversation
1. Avoid undefined references as: undefined reference to `__modsi3' undefined reference to `__umodsi3' 2. We can't remove assembly implementations that are not in the list
Main fix is inside 'utest' all the rest are minor fixes due to the new 'testcrate'. Still allow failures on TravisCI for a while.
testcrate/Cargo.toml
Outdated
| utest-macros = { git = "https://github.com/japaric/utest" } | ||
| test = { git = "https://github.com/paoloteti/utest", branch = "ci" } | ||
| utest-cortex-m-qemu = { default-features = false, git = "https://github.com/paoloteti/utest", branch = "ci" } | ||
| utest-macros = { git = "https://github.com/paoloteti/utest", branch = "ci" } |
There was a problem hiding this comment.
For tracking purposes, are the changes here available as upstream PRs perhaps?
There was a problem hiding this comment.
Yes it is upstream now, I'll update the URL
|
|
||
| [features] | ||
| c = ["compiler_builtins/c"] | ||
| mem = ["compiler_builtins/mem"] | ||
| mangled-names = ["compiler_builtins/mangled-names"] |
There was a problem hiding this comment.
Could this perhaps be turned on by default? I was hoping to keep cargo test working in the testcrate directory "mostly working by default" if possible
There was a problem hiding this comment.
Do you mean 'default = ["mangled-names"]' only ?
testcrate/src/lib.rs
Outdated
| @@ -1,3 +1,5 @@ | |||
| #![cfg_attr(feature = "no_std", no_std)] | |||
There was a problem hiding this comment.
Could this unconditionally be #![no_std]?
There was a problem hiding this comment.
(or this entire file could be emptied)
Fix has been merged into upstream.
Everything default unconditionally to #![no_std].
|
Ok! Regardless though this all looks good to me, so let's land this and then we can edit .travis.yml to start blocking again in a follow-up? @bors: r+ |
|
📌 Commit 9e99aa2 has been approved by |
Fix CI for thumb* targets Main fix is inside `utest` (implement Termination to avoid ICE) all the rest are minor fixes due to the new `testcrate`. Thumb6m needs some extra fixes: some undefined reference and a panic raised removing assembly implementation not in the list. Still allow failures on TravisCI and keep my `utest` fork for a while. Let's see if is stable.
|
☀️ Test successful - status-appveyor, status-travis |
Main fix is inside
utest(implement Termination to avoid ICE) all the rest are minor fixes due to the newtestcrate.Thumb6m needs some extra fixes: some undefined reference and a panic raised removing assembly implementation not in the list.
Still allow failures on TravisCI and keep my
utestfork for a while. Let's see if is stable.