Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always have math functions but with weak linking attribute if we can #577

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Always have math functions but with weak linking attribute if we can #577

merged 2 commits into from
Apr 10, 2024

Commits on Apr 10, 2024

  1. Always have math functions but with weak linking attribute if we can 

    This is a replacement for rust-lang/libm#290

This fixes crashes during compilations for targets that don't have math
symbols by default.

So, we will provide them libm symbols, but mark it as `weak` (if its
supported), so that the linker will choose the system builtin functions,
since those are sometimes more optimized.
If the linker couldn't find those, it will go with `libm`
implementation.
    @Amjad50 @Amanieu
    Amjad50 authored and Amanieu committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    018616e View commit details
    Browse the repository at this point in the history

  2. Do not include math intrinsics for windows and apple targets

    @Amjad50 @Amanieu
    Amjad50 authored and Amanieu committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4d105c9 View commit details
    Browse the repository at this point in the history