Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore blacklisted crates #100

Closed
brson opened this issue Jun 9, 2017 · 3 comments
Closed

Ignore blacklisted crates #100

brson opened this issue Jun 9, 2017 · 3 comments
Labels
C-enhancement Category: enhancement to an existing feature

Comments

@brson
Copy link
Contributor

brson commented Jun 9, 2017

Similar to #99, we maintain a blacklist in blacklist.md of crates with unreliable test suites, but it is not used by cargobomb. Teach cargobomb to ignore these, perhaps by reporting their result as 'blacklisted'.

@brson brson added the C-enhancement Category: enhancement to an existing feature label Jun 9, 2017
@aidanhs
Copy link
Member

aidanhs commented Aug 18, 2017

I'd even propose they don't even get tested since some of them generate multiple GBs of output. E.g. we might have a blacklist.toml like:

bad_crate = "*"
other_crate = "0.1.*"

to specify versions of crates to blacklist

Edit: ah I see in the linked issue you are actually suggesting not doing any work for them.

@eddyb
Copy link
Member

eddyb commented Nov 16, 2017

I have a better idea: have a per-crate "spurious test retry count", such that the crate doesn't show up as failed (at most it shows up as "retried X times") most of the time, without ignoring other causes for failures (e.g. codegen bugs which break the tests consistently).

EDIT: actually, any situation where the succeeded | test-failed | build-failed status is different in before and after, we could automatically retry a few times - they should be in the minority, so not that expensive to do, and would let us triage faster.

@aidanhs
Copy link
Member

aidanhs commented Nov 18, 2017

A brief comment for clarity after talking to @eddyb on IRC: my suggestion for initial blacklist population is for crates that don't work before or after and haven't for (say) three releases. The idea in the comment above is much better for intermittent failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants