-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore blacklisted crates #100
Comments
I'd even propose they don't even get tested since some of them generate multiple GBs of output. E.g. we might have a blacklist.toml like:
to specify versions of crates to blacklist Edit: ah I see in the linked issue you are actually suggesting not doing any work for them. |
I have a better idea: have a per-crate "spurious test retry count", such that the crate doesn't show up as failed (at most it shows up as "retried X times") most of the time, without ignoring other causes for failures (e.g. codegen bugs which break the tests consistently). EDIT: actually, any situation where the |
A brief comment for clarity after talking to @eddyb on IRC: my suggestion for initial blacklist population is for crates that don't work before or after and haven't for (say) three releases. The idea in the comment above is much better for intermittent failures. |
Similar to #99, we maintain a blacklist in blacklist.md of crates with unreliable test suites, but it is not used by cargobomb. Teach cargobomb to ignore these, perhaps by reporting their result as 'blacklisted'.
The text was updated successfully, but these errors were encountered: