krate/publish: Fix VersionReq comparison

rust-lang · Jun 6, 2021 · d1f2826 · d1f2826
1 parent e589429
commit d1f2826
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/controllers/krate/publish.rs b/src/controllers/krate/publish.rs
@@ -303,8 +303,11 @@ pub fn add_dependencies(
             let krate:Crate = Crate::by_exact_name(&dep.name)
                 .first(&*conn)
                 .map_err(|_| cargo_err(&format_args!("no known crate named `{}`", &*dep.name)))?;
-            if semver::VersionReq::parse(&dep.version_req.0) == semver::VersionReq::parse("*") {
-                return Err(cargo_err(WILDCARD_ERROR_MESSAGE));
+
+            if let Ok(version_req) = semver::VersionReq::parse(&dep.version_req.0) {
+                if version_req == semver::VersionReq::STAR {
+                    return Err(cargo_err(WILDCARD_ERROR_MESSAGE));
+                }
             }
 
             // If this dependency has an explicit name in `Cargo.toml` that