Ensure clippy is run for all targets and switch to clippy-preview on stable #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgeibel
force-pushed
the
clippy-preview
branch
from
24acfee to
357a48d
Compare
|
If clippy shipped on stable is recommending something that is not possible on stable, we should open an issue on clippy for that. |
|
It looks like this has been reported upstream in rust-lang/rust#54406. It doesn't affect stable yet, but does affect beta and nightly. I believe the intent is to stabilize this in time for the 2018 edition (see rust-lang/rust#44690 (comment)) so hopefully the allow attribute isn't needed for long. |
jtgeibel
force-pushed
the
clippy-preview
branch
from
357a48d to
5a591b2
Compare
jtgeibel
changed the title
|
I've reworked the implementation and updated the PR description. |
…stable `--all-targets` is now passed to clippy on CI. Temporarily, `-- -A renamed_and_removed_lints` is passed as well. This can be removed once the clippy::* attribute syntax is available in stable. Additionally, clippy-preview is now installed and run on stable. We were previously running clippy on an old nightly from late June and no new warnings (except the one noted above) are raised on nightly so switching to the -preview component on stable shouldn't introduce churn. Also, unlike with rustfmt, we can fix and merge any clippy recommendations before they hit the stable channel, so we don't have to sync with new releases.
jtgeibel
force-pushed
the
clippy-preview
branch
from
5a591b2 to
f6e34a1
Compare
|
Woohoo! I'm excited to not have to keep a particular nightly around anymore :P bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 8, 2018
1493: Ensure clippy is run for all targets and switch to clippy-preview on stable r=carols10cents a=jtgeibel `--all-targets` is now passed to clippy on CI. Temporarily, `-- -A renamed_and_removed_lints` is passed as well. This can be removed once the clippy::* attribute syntax is available in stable. Additionally, clippy-preview is now installed and run on stable. We were previously running clippy on an old nightly from late June and no new warnings (except the one noted above) are raised on nightly so switching to the -preview component on stable shouldn't introduce churn. Also, unlike with rustfmt, we can fix and merge any clippy recommendations before they hit the stable channel, so we don't have to sync with new releases. Co-authored-by: Justin Geibel <jtgeibel@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--all-targetsis now passed to clippy on CI. Temporarily,-- -A renamed_and_removed_lintsis passed as well. This can beremoved once the clippy::* attribute syntax is available in stable.
Additionally, clippy-preview is now installed and run on stable.
We were previously running clippy on an old nightly from late June and
no new warnings (except the one noted above) are raised on nightly so
switching to the -preview component on stable shouldn't introduce
churn. Also, unlike with rustfmt, we can fix and merge any clippy
recommendations before they hit the stable channel, so we don't have to
sync with new releases.