Fix squash message warning. #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jtgeibel (rust-highfive has picked a reviewer for you, use r? to override) |
JohnTitor
reviewed
Aug 15, 2021
src/git.rs
Outdated
Comment on lines
401
to
405
|
|
||
| \n\ | ||
| Previous HEAD was {}, now on the `snapshot-{}` branch\n\n\ | ||
|
|
||
| \n\ | ||
| More information about this change can be found [online] and on [this issue].\n\n\ | ||
|
|
||
| \n\ |
There was a problem hiding this comment.
We could just remove these lines instead of inserting \n, couldn't we? This adds one more blank line so the total number will be 2. I think 1 is fine here.
There was a problem hiding this comment.
Oh, oops! I didn't notice there were already two newlines. I have pushed an update that just removes the blank lines. It's maybe not as clear how it is formatted, though I'm not sure it really matters.
ehuss
force-pushed
the
fix-squash-message
branch
from
cfaedbe
to
8fb8972
Compare
|
@bors r+ |
|
📌 Commit 8fb8972 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#87671 added a warning when backslash continuations eat multiple lines. This uncovered that the message for squashing the index was missing some blank lines. This adds some newlines to silence the warning and fix the message formatting.