Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate lockfile and fetch dependencies outside sandbox on retry #1565

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Generate lockfile and fetch dependencies outside sandbox on retry #1565

merged 3 commits into from
Nov 29, 2021

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Nov 28, 2021

for #1563

@Nemo157 Nemo157 added A-builds Area: Building the documentation for a crate C-bug Category: This is a bug S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 28, 2021
jyn514
jyn514 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the test, feel free to merge when you've made it faster to run :)

@jyn514 jyn514 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 29, 2021
@Nemo157
Copy link
Member Author

Nemo157 commented Nov 29, 2021

Nice, that made the CI/build_tests about 5 minutes faster 😁

@Nemo157 Nemo157 merged commit 6085dba into rust-lang:master Nov 29, 2021
@Nemo157 Nemo157 deleted the fetch-unlocked-deps branch November 29, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @jyn514