Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass rustc-args to build dependencies too #1800

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Aug 23, 2022

This was the previous behaviour before #1559 for the default target and is most likely expected by users.

fixes #1580

This was the previous behaviour before
rust-lang#1559 for the default target
and is most likely expected by users.
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Aug 23, 2022
@Nemo157
Copy link
Member Author

Nemo157 commented Aug 23, 2022

(I'm continuously disappointed that github only displays the committer-date, not the 8 month old author-date).

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thanks!

@jyn514 jyn514 merged commit 3f92a79 into rust-lang:master Aug 24, 2022
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 24, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Aug 27, 2022
@Nemo157 Nemo157 deleted the host-config branch May 31, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass cfg to build script
3 participants