Add line numbers to crate/**/source/
#2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
|
Apart from the small nits, looks great, nice work! |
xFrednet
force-pushed
the
2551-source-line-labels
branch
from
a7c4f6d to
ef58ec2
Compare
GuillaumeGomez
approved these changes
Jul 18, 2024
|
@syphar: We'll really need to add GUI tests for things like source code pages. ^^' |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much what the title says. This adds line numbers to the source view that allow the same selection and URL behavior like rustdoc.
On desktop it looks like this:
And the phone view also works:
I'm not an HTML/CSS expert, and this change proofed that again. It took way too long to get the proper layout. But now it seems to work now, as I wanted. :D
I wasn't able to create the layout using the
pure-*classes, as it would separate the line numbers from the code block for small screens. That's why I added a new class. I'm also not sure if I placed the CSS in the correct files. If you want anything moved around, please let me know!Closes: #2551
r? syphar
Also thank you to @syphar for giving me guidance in the issue! ❤️