add settings.js to essential files #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2019
Closed
|
CI failure looks spurious. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 15, 2019
…h, r=GuillaumeGomez rustdoc: use --static-root-path for settings.js At the time i was writing rust-lang/docs.rs#332, i noticed that the `settings.js` file that was being loaded was not being loaded from the `--static-root-path`. This PR fixes that so that users on docs.rs can effectively cache this file.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 16, 2019
…h, r=GuillaumeGomez rustdoc: use --static-root-path for settings.js At the time i was writing rust-lang/docs.rs#332, i noticed that the `settings.js` file that was being loaded was not being loaded from the `--static-root-path`. This PR fixes that so that users on docs.rs can effectively cache this file.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 16, 2019
…h, r=GuillaumeGomez rustdoc: use --static-root-path for settings.js At the time i was writing rust-lang/docs.rs#332, i noticed that the `settings.js` file that was being loaded was not being loaded from the `--static-root-path`. This PR fixes that so that users on docs.rs can effectively cache this file.
QuietMisdreavus
force-pushed
the
new-files
branch
from
2a97f05 to
c276bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213, though all the existing
settings.jsfiles need to be loaded in separately. Can be deployed without updating rustdoc at the same time, since this file has been there for a while>_>In rust-lang/rust#49954, rustdoc added a settings menu, which added the separate JavaScript file
settings.js. This is a static file just like the other JS/CSS files bundled with rustdoc, but docs.rs never picked it up as an essential file.A separate change will need to be made to rustdoc to use
--static-root-pathfor this file, but this can at least let users begin using the settings page.