Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edition notes about ? #111

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Conversation

mark-i-m
Copy link
Member

cc rust-lang/rust#51934

The new Kleene op is not stable yet, but the removal of ? as a separator is. I can split this up into two PRs if you want.

@Centril
Copy link
Contributor

Centril commented Sep 22, 2018

Please include a note that ? is unstable :)

@mark-i-m
Copy link
Member Author

I wasn't sure if we wanted to wait until ? was stable before merging this or if we want to include notes in the edition guide about planned-but-currently-unstable features. If we are planning to merge this now, I can add a note about unstable-ness...

@Centril
Copy link
Contributor

Centril commented Sep 22, 2018

I would at least like to document the edition breakage soon -- if you want to you can split up the PR to include only the breakage.

@steveklabnik
Copy link
Member

I wasn't sure if we wanted to wait until ? was stable before merging this or if we want to include notes in the edition guide about planned-but-currently-unstable features. If we are planning to merge this now, I can add a note about unstable-ness...

Is this planned on being stable before the edition ships, or after?

@mark-i-m
Copy link
Member Author

Likely after.

@mark-i-m
Copy link
Member Author

mark-i-m commented Nov 3, 2018

rust-lang/rust#48075 is going through stabilization, so this will likely be available in 1.32 or so...

@Centril
Copy link
Contributor

Centril commented Dec 2, 2018

@mark-i-m Now that we've stabilized ?, want to fix this PR up so we can merge? :)

@mark-i-m mark-i-m force-pushed the macro_at_most_once_rep branch from c5eb0c9 to ab2c46c Compare December 3, 2018 19:01
@mark-i-m
Copy link
Member Author

mark-i-m commented Dec 3, 2018

@Centril Done 👍

@Centril
Copy link
Contributor

Centril commented Dec 3, 2018

Thanks!

@Centril Centril merged commit f5f37f5 into rust-lang:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants