Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

futures-preview-0.3.0-alpha.13 build fails on nightly-2019-04-08 or later #1518

Closed
taiki-e opened this issue Apr 8, 2019 · 2 comments
Closed

Comments

@taiki-e
Copy link
Member

taiki-e commented Apr 8, 2019

Probably it will take a while to release the next version.

It can be avoided by pinning the nightly toolchain to the 2019-04-07 or early.

@Nemo157
Copy link
Member

Nemo157 commented Apr 15, 2019

Now that #1514 has been merged master once again works on the latest nightly (for now...). If you want to prepare for the new release (or have other reasons you can't stay on nightly-2019-04-07 or earlier) you can override the crate in your Cargo.toml:

[patch.crates-io]
futures-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }
futures-core-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }
futures-util-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }
futures-sink-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }
futures-channel-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }
futures-executor-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }
futures-io-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }
futures-test-preview = { git = "https://github.com/rust-lang-nursery/futures-rs" }

this will apply throughout your dependency tree, so will likely fail if you have dependencies that directly implement the Future trait unless they also prepare for the next version, but ¯\_(ツ)_/¯ such is life on nightly (and thank you to everyone that is willing to help test this stuff while it's on nightly).

@vorot93
Copy link
Contributor

vorot93 commented Apr 15, 2019

@cramertj This can be closed now, I believe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants