Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no_std only when std feature is not enabled #1297

Merged
merged 1 commit into from
Oct 19, 2018
Merged

no_std only when std feature is not enabled #1297

merged 1 commit into from
Oct 19, 2018

Conversation

cramertj
Copy link
Member

Fix #1296

seanmonstar
seanmonstar approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops XD

@cramertj
Copy link
Member Author

Well, it used to work on the 2018 edition, but then I complained and it got fixed! XD go figure

@cramertj
Copy link
Member Author

(see rust-lang/rust#53166 for context)

@cramertj cramertj merged commit 7fd5a41 into rust-lang:master Oct 19, 2018
@cramertj cramertj deleted the fix-nightly-std branch October 19, 2018 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

@aturon aturon Awaiting requested review from aturon

@Nemo157 Nemo157 Awaiting requested review from Nemo157

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cramertj @seanmonstar