Move non-stable Rust features behind Cargo features #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
reviewed
Apr 25, 2019
cramertj
reviewed
Apr 25, 2019
taiki-e
reviewed
Apr 25, 2019
futures-util/src/lib.rs
Outdated
| @@ -2,7 +2,7 @@ | |||
| //! and the `AsyncRead` and `AsyncWrite` traits. | |||
|
|
|||
| #![cfg_attr(feature = "alloc", feature(box_into_pin))] | |||
There was a problem hiding this comment.
box_into_pin is also an unstable feature.
There was a problem hiding this comment.
😲 why is this not failing in travis then.
Oh, allow-features is only for language features. Is there any way to deny library features as well?
There was a problem hiding this comment.
No, I don't believe so-- seems like a reasonable thing to add to allow-features (cc @tmandry).
|
Looks like there are some conflicts with master-- will merge when those are resolved. Thanks again for this-- it's super exciting! :) |
|
@cramertj rebased |
|
Is there a plan to put a new alpha release on crates.io once this is merged? |
|
@sdroege Yup, I'll get a new alpha release out today. |
This was referenced Apr 27, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the crates to a point where they should compile on stable 1.36 when it is released. The travis jobs have been updated to make the compiler act like a stable compiler where possible to catch any regressions.