Use #![warn(single_use_lifetimes)] #1680
Conversation
|
Hmm... this causes many warnings in older versions: https://travis-ci.com/rust-lang-nursery/futures-rs/jobs/209181035 |
taiki-e
force-pushed
the
single_use_lifetimes
branch
from
226013e
to
824488a
Compare
| @@ -9,6 +9,8 @@ | |||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
|
|
|||
| #![warn(missing_docs, missing_debug_implementations, rust_2018_idioms, unreachable_pub)] | |||
| // It cannot be included in the published code because this lints have false positives in the minimum required version. | |||
| #![cfg_attr(test, warn(single_use_lifetimes))] | |||
There was a problem hiding this comment.
This enables single_use_lifetimes lint when running cargo test, cargo check --tests etc. (FWIW, I often run cargo check --all-features --tests --all locally before opening PR).
|
There are still warnings at |
Given the reason for checking them, |
| @@ -22,4 +22,4 @@ std = [] | |||
| proc-macro2 = "0.4" | |||
| proc-macro-hack = "0.5.3" | |||
| quote = "0.6" | |||
| syn = { version = "0.15.22", features = ["full"] } | |||
| syn = { version = "0.15.25", features = ["full"] } | |||
There was a problem hiding this comment.
A warning occurred when building with minimal versions: https://travis-ci.com/rust-lang-nursery/futures-rs/jobs/209211855. (that warning was fixed in dtolnay/syn#563, and that change is included in 0.15.25 and later versions)
(Context: After the first commit, I realized that CI did not catch(and reject) the warnings, so I added eb4cbfa and changed the warnings to be denied for all builds.)
I tried to do this at the time of #1531, but I couldn't do it because of rust-lang/rust#53738 (It needed too much
#[allow(single_use_lifetimes)]...).