Revert #81, #82, #83 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts three recent PRs to the `getopts` crate. One of the main consumers of `getopts` is `rustc`, which isn't allowed to have breaking changes. In rust-lang#82, however, a breaking change was landed. It looks like rust-lang#83 builds on this change, and while rust-lang#81 seems unrelated the diffs were somewhat tangled.
|
cc @jridgewell, I'm sorry we've gotta revert so quickly but I've got changes to publish to If you're still interested in having these changes landed in the crate, perhaps a config option could be added to enable this new behavior so it's not a breaking change and crates can opt-in to this CLI behavior? |
|
Ah whoops! I hadn't realized we depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts three recent PRs to the
getoptscrate. One of themain consumers of
getoptsisrustc, which isn't allowed to havebreaking changes. In #82, however, a breaking change was landed. It
looks like #83 builds on this change, and while #81 seems unrelated the
diffs were somewhat tangled.