Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: replace structopt with clap #1007

Merged
merged 1 commit into from
Mar 14, 2024
Merged

examples: replace structopt with clap #1007

merged 1 commit into from
Mar 14, 2024

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Jan 7, 2024

See TeXitoi/structopt#525.

Currently git2 is the most downloaded dependent of structopt:
https://crates.io/crates/structopt/reverse_dependencies.

@tamird tamird force-pushed the clap branch 2 times, most recently from cccdde2 to c8f07ab Compare January 11, 2024 16:32
@tamird
Copy link
Contributor Author

tamird commented Jan 11, 2024

@ehuss this is green now that you merged #1008. Could you take a look please?

@tamird
Copy link
Contributor Author

tamird commented Jan 15, 2024

@ehuss friendly ping!

@tamird
Copy link
Contributor Author

tamird commented Feb 22, 2024

@ehuss ping.

@tamird
Copy link
Contributor Author

tamird commented Mar 14, 2024

@epage can you merge it?

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue Mar 14, 2024
Merged via the queue into rust-lang:master with commit a75e007 Mar 14, 2024
7 checks passed
@tamird tamird deleted the clap branch March 14, 2024 17:54
@tamird
Copy link
Contributor Author

tamird commented Mar 14, 2024

Thanks! Would it be possible to cut a patch release?

@ehuss
Copy link
Contributor

ehuss commented Mar 14, 2024

Can you say more about what you are looking for in a new release? I don't expect people are using the examples directly, and it shouldn't have any impact on the git2-rs library.

@tamird
Copy link
Contributor Author

tamird commented Mar 14, 2024

Ah, it's a dev dependency. My mistake. The only thing a release would do is remove git2-rs from the rankings.

@rpelliard rpelliard mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants