-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git2_ureq transport #625
Conversation
Also note this actually won't compile with ureq 1.4.1. I needed to make some local changes to add Send + Sync to the return value of into_reader, which I'll upstream now. |
Nice! This seems pretty reasonable to me to add! I haven't looked at git2-curl in a very long time though so some things could probably be improved there, but this seems like a great start at least! |
Updated to refer to a released version of ureq with the needed Send marker. I also refactored significantly to better reflect my understanding of how things work. Definitely interested in feedback on code structure and style. |
Also, call it version 1.0.0.
I'm actually going to close this for now. When I went deeper on integrating this with cargo, I realized the other fetches in cargo (the crate downloads) rely on HTTP/2 for a significant speedup. Since |
This is an alternate approach to #624 that uses an actual HTTP client (ureq) on top of rustls. In the end this came out significantly cleaner, and by using default_features = false I was able to keep the dependencies very minimal.
Note that this branch is built on top of the branch for #624 for convenience. If we decide to go this route I'll excise the git2_rustls files.