Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing semicolon from internal err! macro #631

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

Aaron1011
Copy link
Member

This will allow this crate to continue to compile if
rust-lang/rust#33953 is fixed

This will allow this crate to continue to compile if
rust-lang/rust#33953 is fixed
@Aaron1011
Copy link
Member Author

Blocked on rust-lang/rustfmt#4507

@Aaron1011
Copy link
Member Author

This PR's code is now accepted by the latest nightly rustfmt: rustfmt 1.4.27-nightly (580d826 2020-11-16)

It looks like CI is gating on rustfmt for stable 1.47.0. Do I need to wait for a stable release containing the rustfmt fix before this PR can be merged?

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.49 is now stable, so I think it is safe to merge this.

@ehuss ehuss merged commit b5d3b5c into rust-lang:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants