Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "extern crate" directions from README #131

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

zmitchell
Copy link
Contributor

You no longer need to add extern crate directives for modern Rust editions.

You no longer need to add `extern crate` directives for modern Rust editions.
@JohnTitor
Copy link
Member

Thanks! Our MSRV is, however, 1.23.0 and it's still needed on such an old version. Maybe we should mention it instead of just removing, like:

If you're using Rust 1.30 or earlier, or edition 2015, add this to your crate root:

@zmitchell
Copy link
Contributor Author

Done

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JohnTitor JohnTitor merged commit 41f93af into rust-lang:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants