Miri can catch panics now #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
commented
Dec 6, 2019
Comment on lines
-3380
to
3382
| // FIXME: https://github.com/rust-lang/miri/issues/653 | ||
| let mut rng = { | ||
| let seed = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]; | ||
| SmallRng::from_seed(seed) |
There was a problem hiding this comment.
This issue has been closed, meaning getrandom now works on Miri. This is still not host randomness by default; see the Miri README. But wouldn't it be better to keep this test deterministic? That's why I didn't change the code.
|
CI failures look unrelated: |
|
blocked on cross-rs/cross#357 |
|
@bors r+ |
|
📌 Commit 4ccc1a2 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 21, 2019
Miri can catch panics now Also update some other Miri-related comments.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update some other Miri-related comments.