Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname on xtensa esp-idf esp32s3 #3748

Closed
lorenzo-pirchio opened this issue Jun 14, 2024 · 3 comments · Fixed by #3934
Closed

Hostname on xtensa esp-idf esp32s3 #3748

lorenzo-pirchio opened this issue Jun 14, 2024 · 3 comments · Fixed by #3934
Labels
C-API-request Category: API request E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@lorenzo-pirchio
Copy link

Hi,
I need to use hostname_max and the function gethostname for xtensa-esp32s3-espidf but they're not supported for this target.
Can anyone give me any suggestion or help?
Thanks

@tgross35
Copy link
Contributor

PRs are welcome here! Take a look at https://github.com/rust-lang/libc/blob/1ffe0bde929a43ce3d25a8f08b9f95bde8d3e5d8/CONTRIBUTING.md, it should be pretty easy to add the API on those platforms.

@tgross35 tgross35 added C-API-request Category: API request help wanted labels Aug 15, 2024
@tgross35 tgross35 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. and removed help wanted labels Aug 29, 2024
@Laura7089
Copy link
Contributor

Laura7089 commented Sep 18, 2024

I'm interested in picking this up. As far as I can tell, libc doesn't currently support that target - support for it in rust was merged as Tier 3 here: rust-lang/rust#126380. Is there a guide/policy for adding target support to the libc crate?

@Vollbrecht
Copy link

There is no written guide for this target specifically that i am aware off. Though the target ( and all other -espidf targets ) are using a version of newlib that is directly integrated in the underlying esp-idf system. Depending on the version of the esp chip there are parts of this newlib library directly inside the ROM.

Here you can find the in tree version of newlib that is used in ESP_IDF version 5.2.2.

What actually lives inside the ROM's is tracked inside this repository

We have one outstanding PR that does a bit of cleanup inside libc with respect to correct constants. There you see for example how the rust libc site and the esp_idf site can be checked against each other.

If you have any target specific questions all the maintainers are also available in our esp-rs matrix channel found here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-API-request Category: API request E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants