Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_hostname to esp-idf #3934

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Add get_hostname to esp-idf #3934

merged 4 commits into from
Nov 13, 2024

Conversation

Laura7089
Copy link
Contributor

@Laura7089 Laura7089 commented Sep 18, 2024 •
edited
Loading

This PR adds:

  • gethostname (found here in the ESP newlib fork, and here in esp-idf-svc)
  • _SC_HOST_NAME_MAX (found here)

to espidf.

Closes #3748.

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@Laura7089
Copy link
Contributor Author

There is currently not a corresponding semver symbol check file (that I can find) for the ESP - am I looking in the wrong place?

@Laura7089
Copy link
Contributor Author

@rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 18, 2024
@Laura7089

This comment was marked as outdated.

Sign in to view
@tgross35
Copy link
Contributor

There is currently not a corresponding semver symbol check file (that I can find) for the ESP - am I looking in the wrong place?

There isn't one, but feel free to start one. It won't get checked against anything for now but we can add it in the future.

Closes #3748.

Goes in the PR description :)

Could you please add a link to the relevant headers providing these in the PR description?

@rustbot author

(just comment @rustbot review when it is ready for a look)

@Laura7089 Laura7089 changed the title Add get_hostname and _SC_HOST_NAME_MAX to esp-idf Add get_hostname to esp-idf Oct 21, 2024
@Laura7089
Copy link
Contributor Author

I'm having some trouble finding concrete definitions of HOST_NAME_MAX (or similar) in the ESP-IDF documentation or the newlib repo. Is it possible it's not defined in the IDF?

@Laura7089
Copy link
Contributor Author

@rustbot review

@tgross35
Copy link
Contributor

tgross35 commented Nov 6, 2024

I think this should be good, but it needs a rebase and to be marked ready for review. Unless you were waiting for confirmation on HOST_NAME_MAX?

@rustbot author

@Laura7089 Laura7089 marked this pull request as ready for review November 7, 2024 13:39
@Laura7089
Copy link
Contributor Author

Laura7089 commented Nov 7, 2024 •
edited
Loading

sort appears to change its behaviour based on the LC_COLLATE environment variable - may I suggest setting this in ci/style.sh to disambiguate the desired sort order?

@Laura7089
Copy link
Contributor Author

@rustbot review

tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 12, 2024
@tgross35
Ensure that calls to sort do not depend on locale
a88c0d3 
Fixes: rust-lang#3934 (comment)
@tgross35 tgross35 mentioned this pull request Nov 12, 2024
Merged
@tgross35 tgross35 reopened this Nov 13, 2024
@tgross35 tgross35 force-pushed the feat/esp-idf-hostname branch from 936b5d2 to e7d4663 Compare November 13, 2024 07:49
@tgross35
Copy link
Contributor

sort appears to change its behaviour based on the LC_COLLATE environment variable - may I suggest setting this in ci/style.sh to disambiguate the desired sort order?

Good idea, done in #4026

@tgross35 tgross35 enabled auto-merge November 13, 2024 07:50
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 13, 2024
@tgross35
Ensure that calls to sort do not depend on locale
058185a 
Fixes: rust-lang#3934 (comment)

(backport <rust-lang#4026>)
(cherry picked from commit a88c0d3)
@tgross35 tgross35 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into rust-lang:main with commit 600e1d1 Nov 13, 2024
43 checks passed
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 15, 2024
@tgross35
Merge pull request rust-lang#3934 from Laura7089/feat/esp-idf-hostname
bd00c8e 
Add `get_hostname` to esp-idf

(backport <rust-lang#3934>)
(cherry picked from commit 600e1d1)
@tgross35 tgross35 mentioned this pull request Nov 15, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch stable-nominated This PR should be considered for cherry-pick to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch stable-applied This PR has been cherry-picked to libc's stable release branch labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hostname on xtensa esp-idf esp32s3
4 participants
@Laura7089 @rustbot @tgross35 @JohnTitor