Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support pipe2 on BSD #500

Closed
oconnor663 opened this issue Jan 25, 2017 · 4 comments
Closed

support pipe2 on BSD #500

oconnor663 opened this issue Jan 25, 2017 · 4 comments

Comments

@oconnor663
Copy link
Contributor

Right now it's only available in the notbsd subtree, but it looks like the BSD's support it?

https://www.freebsd.org/cgi/man.cgi?query=pipe&sektion=2
http://netbsd.gw.com/cgi-bin/man-cgi?pipe2+2+NetBSD-current
http://man.openbsd.org/pipe.2

I might try moving it up to src/unix/mod.rs in a PR just to see what happens. Maybe Apple doesn't support it? Let me know if there's an easy way to figure this out without just seeing what breaks :)
oconnor663 added a commit to oconnor663/libc that referenced this issue Jan 25, 2017
@oconnor663
try moving pipe2 from notbsd to unix
c97cbc5 
rust-lang#500
@oconnor663 oconnor663 mentioned this issue Jan 25, 2017
Closed
@oconnor663
Copy link
Contributor Author

Yep, it breaks on OSX. Would the right thing to do be to individually add it to the other BSD flavors?

@oconnor663
Copy link
Contributor Author

Related question: nix currently hardcodes the platforms that support this call, https://github.com/nix-rust/nix/blob/master/src/unistd.rs#L617-L619. If we add more platforms, nix will want to update those lines. Is there a way for nix to avoid this kind of hardcoding?

@alexcrichton
Copy link
Member

AFAIK there's no way to avoid hardcoding down the road, but yeah you can just add it to the BSD modules

@oconnor663 oconnor663 mentioned this issue Jan 25, 2017
Merged
bors added a commit that referenced this issue Jan 25, 2017
@bors
Auto merge of #502 - oconnor663:pipe2_bsd, r=alexcrichton
bce927b 
add pipe2 to non-OSX BSD's

#500
@oconnor663
Copy link
Contributor Author

Closing since #502 has landed.

danielverkamp pushed a commit to danielverkamp/libc that referenced this issue Apr 28, 2020
@gnzlbg
Calling xgetbv is safe only if the OS has set osxsave.
636dca6 
Closes rust-lang#500.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @oconnor663