libc: changes to ppc64le musl branch to support building of rust on A… #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This was referenced Jun 18, 2018
…lpine amend to add style changes amend to add style changes
|
@bors: r+ Thanks! |
|
📌 Commit dcff154 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 28, 2018
libc: changes to ppc64le musl branch to support building of rust on A… …lpine This PR includes changes to the libc musl branch to include the correct defines & declarations to support powerpc64. Values that needed changes to a definition for powerpc64.rs that existed higher in the branch also resulted in a change that moved the definition down to the b32/mod.rs, b64/x86_64.rs to ensure that builds continued to work on those architectures. Verification was done building rust for both ppc64le and x86_64 on Alpine as described in the git project https://github.com/mksully22/ppc64le_alpine_rust_1.26.2
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Jul 1, 2018
Re-add aarch64 stuff removed by previous PR Previous PR #1023 has removed stuff from mod.rs and added it to some submodules, but missed the aarch64 submodule. This caused a build failure for rust on aarch64, see rust-lang/rust#51864. This copies the stuff that that commit added to the x86_64.rs submodule and puts it into aarch64.rs. It's been tested in the rust-lang/rust PR above: https://travis-ci.org/rust-lang/rust/builds/398750336
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jul 5, 2018
rust: add initial changes to support powerpc64le musl Initial changes to support rustc building on ppc64le with musl. A PR was also submitted to libc component rust-lang/libc#1023 to add changes to libc musl definitions. A PR was submitted on Alpine alpinelinux/aports#4549 with equivalent temporary patches for building on Alpine for now. As a verification test a github project was put together to build ppc64le versions of rustc, rust-stdlib, and cargo on Alpine, https://github.com/mksully22/ppc64le_alpine_rust_1.26.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lpine
This PR includes changes to the libc musl branch to include the correct defines & declarations to support powerpc64. Values that needed changes to a definition for powerpc64.rs that existed higher in the branch also resulted in a change that moved the definition down to the b32/mod.rs, b64/x86_64.rs to ensure that builds continued to work on those architectures.
Verification was done building rust for both ppc64le and x86_64 on Alpine as described in the git project
https://github.com/mksully22/ppc64le_alpine_rust_1.26.2