Add more WASI libc bindings #1325
Conversation
Rustc is changing it to be target_os; for now, recognize both.
Also, locale_t is a typedef for a pointer to an opaque struct, so represent it that way explicitly.
dirent contains a flexible array member, so don't test its sizeof, don't allow it to be copied, and don't represent it with an artificial size.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit ef7ae73 has been approved by |
Add more WASI libc bindings This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
|
💔 Test failed - checks-travis |
This contains several fixes, including the FD_ISSET signature change that the previous patch in this PR needs.
|
@bors: r+ |
|
📌 Commit edd541e has been approved by |
Add more WASI libc bindings This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
|
💔 Test failed - checks-travis |
fd_set isn't automatically copyable. While it will be possible to fix that, for now just remove these so that they don't block other changes.
|
@sunfishcode note that if you want to use travis for testing you can comment out all "irrelevant" build jobs in a commit, so that travis only tests the relevant ones for the PR, and once those are green, kill the commit. |
|
@gnzlbg That's good to know, thanks! In any case though, the CI is now green here. |
|
@bors: r+ |
|
📌 Commit 13ddc16 has been approved by |
Add more WASI libc bindings This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
|
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular,
cargo test --allincluding libc-test now builds successfully.