Some update for vxWorks #1473
Some update for vxWorks #1473
Conversation
…askDelay() 2. change armv7-wrs-vxworks to armv7-wrs-vxworks-eabihf 3. code cleanup
code cleanup and adding randBytes() etc
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Adding to @BaoshanPang 's overview of the changes:
|
|
OK I think we kicked this off a tad too early. The rust-lang.libc test failed because we haven't yet picked up our compiler changes from |
src/vxworks/mod.rs
Outdated
| all(target_os = "macos", target_arch = "x86"), | ||
| link_name = "munmap$UNIX2003" | ||
| )] | ||
|
|
src/vxworks/mod.rs
Outdated
| pub fn localtime(time_p: *const time_t) -> *mut tm; | ||
| */ | ||
| #[cfg_attr(target_os = "netbsd", link_name = "__difftime50")] | ||
|
|
remove spurious extra line
|
The error here seems nothing to do with my change: https://github.com/rust-lang/libc/pull/1473/checks?check_run_id=196203151 |
|
@bors: r+ |
|
📌 Commit e43e863 has been approved by |
Some update for vxWorks This is to address issues: #1469 and rust-random/getrandom#86 (comment) What have been changed in this PR: 1. adding randBytes(), randABytes(), randUBytes(), randSecure() and taskDelay() 2. change armv7-wrs-vxworks to armv7-wrs-vxworks-eabihf 3. code cleanup
|
Is this a known issue? I see the test is still failing on the same issue. |
|
💥 Test timed out |
It looks like we are using newer version bootstrap compiler which have more strict warning/error level. |
|
@bors: retry |
Some update for vxWorks This is to address issues: #1469 and rust-random/getrandom#86 (comment) What have been changed in this PR: 1. adding randBytes(), randABytes(), randUBytes(), randSecure() and taskDelay() 2. change armv7-wrs-vxworks to armv7-wrs-vxworks-eabihf 3. code cleanup
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
|
@gnzlbg |
|
@gnzlbg |
|
Probably some time after rust-lang/rust#63806 lands. |
This is to address issues:
#1469 and rust-random/getrandom#86 (comment)
What have been changed in this PR: