Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeBSD10 build job #1491

Closed
wants to merge 10 commits into from
Closed

Add FreeBSD10 build job #1491

wants to merge 10 commits into from

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Aug 24, 2019

No description provided.

@rust-highfive
Copy link

@gnzlbg: no appropriate reviewer found, use r? to override

@gnzlbg gnzlbg closed this Aug 25, 2019
@gnzlbg gnzlbg reopened this Aug 25, 2019
@gnzlbg gnzlbg force-pushed the freebsd10 branch 2 times, most recently from efee8ae to a82f231 Compare August 25, 2019 12:44
@gnzlbg gnzlbg mentioned this pull request Aug 25, 2019
Closed
asomers
asomers reviewed Aug 25, 2019
View reviewed changes
Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ppoll first appeared in FreeBSD 11, so we probably shouldn't define it when freebsd10 is set.

libc-test/build.rs Outdated Show resolved Hide resolved
@gnzlbg gnzlbg mentioned this pull request Sep 2, 2019
Merged
asomers
asomers reviewed Sep 2, 2019
View reviewed changes
Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need to do this? The FreeBSD 10 series is EOL.

libc-test/build.rs
cfg.define("_WANT_FREEBSD11_STAT", None);
match freebsd_ver {
Some(10) => &mut cfg,
_ => cfg.define("_WANT_FREEBSD11_STAT", None),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need this symbol . This is only needed on 12+ to expose the backwards-compatible definition of struct stat under a different name, and libc doesn't appear to be doing anything with it.

libc-test/build.rs
}

// FIXME: This constant has a different value in FreeBSD 10:
"RLIM_NLIMITS" if Some(10) == freebsd_ver => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant shouldn't even be defined by libc. I'm going to open a new PR to deprecate it.

@bors
Copy link
Contributor

bors commented Sep 7, 2019

☔ The latest upstream changes (presumably #1497) made this pull request unmergeable. Please resolve the merge conflicts.

@gnzlbg gnzlbg closed this Sep 16, 2019
@gnzlbg gnzlbg mentioned this pull request Sep 16, 2019
Merged
bors added a commit that referenced this pull request Sep 21, 2019
@bors
Auto merge of #1518 - gnzlbg:freebsd10support, r=gnzlbg
f66ba4f 
Add FreeBSD10 support

This adds libc-test support for Freebsd10 and a CI build job that tests
FreeBSD10 with LIBC_CI only.

cc @asomers this is a follow up to #1491 .
bors added a commit that referenced this pull request Sep 21, 2019
@bors
Auto merge of #1518 - gnzlbg:freebsd10support, r=gnzlbg
58b2706 
Add FreeBSD10 support

This adds libc-test support for Freebsd10 and a CI build job that tests
FreeBSD10 with LIBC_CI only.

cc @asomers this is a follow up to #1491 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnzlbg @rust-highfive @bors @asomers