Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AIO_LISTIO_MAX #1498

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Deprecate AIO_LISTIO_MAX #1498

merged 1 commit into from
Sep 7, 2019

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Sep 2, 2019

This value can vary at runtime. Applications should instead use
sysconf(3) with _SC_AIO_LISTIO_MAX.

This value can vary at runtime.  Applications should instead use
sysconf(3) with _SC_AIO_LISTIO_MAX.
@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@asomers
Copy link
Contributor Author

asomers commented Sep 2, 2019

BTW, POSIX says that this constant shouldn't even be defined on systems (like FreeBSD and Apple) that publish its value through sysconf:
https://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.html

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 7, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 7, 2019

📌 Commit 1be630f has been approved by gnzlbg

bors added a commit that referenced this pull request Sep 7, 2019
Deprecate AIO_LISTIO_MAX

This value can vary at runtime.  Applications should instead use
sysconf(3) with _SC_AIO_LISTIO_MAX.
@bors
Copy link
Contributor

bors commented Sep 7, 2019

⌛ Testing commit 1be630f with merge 28fdbe6...

@bors
Copy link
Contributor

bors commented Sep 7, 2019

💔 Test failed - status-azure

@asomers
Copy link
Contributor Author

asomers commented Sep 7, 2019

Looks like the same libc bug that affects the nightly Rust stdlib.

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 7, 2019

@bors: retry

Looks like the same libc bug that affects the nightly Rust stdlib.

The failure is in azure.

@bors
Copy link
Contributor

bors commented Sep 7, 2019

⌛ Testing commit 1be630f with merge 9c2b839...

bors added a commit that referenced this pull request Sep 7, 2019
Deprecate AIO_LISTIO_MAX

This value can vary at runtime.  Applications should instead use
sysconf(3) with _SC_AIO_LISTIO_MAX.
@bors
Copy link
Contributor

bors commented Sep 7, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 9c2b839 to master...

@bors bors merged commit 1be630f into rust-lang:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants