-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose futimens() for illumos systems #1607
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ |
📌 Commit ca3eb03 has been approved by |
expose futimens() for illumos systems illumos has an implementation of `futimens()` which we should expose. I'm working on a broader set of [fixes for illumos](master...jclulow:illumos_fixes) in general, but that's going to take a lot more work to be ready so the test suite doesn't currently seem to function.
💔 Test failed - status-azure |
Apologies for missing the style check. I'll fix it up. |
@bors: r+ |
📌 Commit 223e7d3 has been approved by |
expose futimens() for illumos systems illumos has an implementation of `futimens()` which we should expose. I'm working on a broader set of [fixes for illumos](master...jclulow:illumos_fixes) in general, but that's going to take a lot more work to be ready so the test suite doesn't currently seem to function.
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
illumos has an implementation of
futimens()
which we should expose. I'm working on a broader set of fixes for illumos in general, but that's going to take a lot more work to be ready so the test suite doesn't currently seem to function.