Add TCP FastOpen support for macOS #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@gnzlbg Hello, could you review this PR? |
gnzlbg
approved these changes
Jan 2, 2020
|
@mati865 @pietroalbini there are many linker failures across the board of the form that are unrelated to this PR: Do these look familiar ? |
|
I think there were changes to |
|
This one? Looks potentially related: rust-lang/cc-rs#461 cc @alexcrichton |
|
It's not yet published so it was something else, Docker images shouldn't have changed AFAIK. |
|
Wait, |
|
I'll cc @ehuss ^ Possibly |
|
Hm, sorry, that was an unexpected regression. I'll work on a fix today, though it may take until sometime next week to get into nightly. |
|
@ehuss do you know which cargo PR caused it? I skimmed through the closed PR queue and couldn't find anything that ringed a bell. |
|
I think that is rust-lang/cargo#7649 and that's why I pointed to cargo (I knew about this PR before). |
|
Fix has been posted at rust-lang/cargo#7763. |
|
The fix should be in the latest nightly (2020-01-08). |
|
@gnzlbg Could you trigger rebuild? |
|
@gnzlbg Hello, when could this PR be merged? |
|
Hey @zonyitoo, could you rebase to make sure things? |
|
r? @JohnTitor |
This comment has been minimized.
This comment has been minimized.
|
Style check complains about line length, could you fix it? |
JohnTitor
reviewed
Feb 20, 2020
database64128
added a commit
to database64128/libc
that referenced
this pull request
Mar 3, 2023
This is used to disable the backoff mechanism, otherwise TFO is basically unusable. Updates rust-lang#1632 and rust-lang#1635 Definition: https://github.com/apple/darwin-xnu/blob/2ff845c2e033bd0ff64b5b6aa6063a1f8f65aa32/bsd/netinet/tcp.h#L310 Related commits/PRs: zonyitoo/tokio-tfo#5, database64128/tfo-go@c980f6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1632