-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RLIMIT_* constants for RISC-V 64-bit GNU/Linux and minor fixes for type definitions #1745
Conversation
r? @JohnTitor (rust_highfive has picked a reviewer for you, use r? to override) |
That doesn't make sense. PTRACE_GETREGS, PTRACE_SETREGS, PTRACE_GETFPREGS, PTRACE_SETFPREGS, PTRACE_GETFPXREGS, PTRACE_SETFPXREGS don't exist on riscv64, and PTRACE_PEEKSIGINFO_SHARED is not architecture dependent. |
b1856e2
to
5509977
Compare
I checked and it seems like those constants are not in the Linux headers for riscv64 but it is still in the glibc headers and therefore is mistakenly included. |
PTRACE_PEEKSIGINFO_SHARED is arch-independent but is not present in arch-independent files so this should be fixed in another PR. |
5509977
to
938ad95
Compare
There is still another part of this PR for minor type definition fixes by removing redundant type definitions that is already in the platform-independent type defintions. |
This just forces effective-limits to use a patched libc with riscv64-unknown-linux-gnu support for RLIMIT constants. See rust-lang/libc#1745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
The riscv65gc-unknown-linux-gnu target requires fixes in rust-lang/libc#1745. These are merged but aren't in a release yet.
This just forces effective-limits to use a patched libc with riscv64-unknown-linux-gnu support for RLIMIT constants. See rust-lang/libc#1745
This just forces effective-limits to use a patched libc with riscv64-unknown-linux-gnu support for RLIMIT constants. See rust-lang/libc#1745
libc 0.2.70 includes rust-lang/libc#1745 which fixes compilation for riscv64gc-unknown-linux-gnu.
libc 0.2.70 includes rust-lang/libc#1745 which fixes compilation for riscv64gc-unknown-linux-gnu.
No description provided.