-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ucontext_t for aarch64-unknown-linux-musl #1863
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
1ca768f
to
eb618e2
Compare
Did you test with this workaround? I guess we could auto-derive it here as well... libc/src/unix/linux_like/linux/gnu/b64/aarch64/align.rs Lines 25 to 27 in 035a480
|
I tried it but the math doesn't work out in this case. The prime factorization of |
Ah, makes sense. I'd still prefer to auto-derive it as this will make the difference between arch/env and users will be confused. |
(Note that CI will fail anyway until #1865 gets merged.) |
Looks good except for spurious failures. Could you rebase and squash commits into one? |
e385d17
to
2259b0b
Compare
@JohnTitor squashed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
See: bytecodealliance/wasmtime#2133