-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test infrastructure #2109
Add regression test infrastructure #2109
Conversation
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #2113) made this pull request unmergeable. Please resolve the merge conflicts. |
@JohnTitor before I rebase could you review this first? |
One question is how we deal with the FreeBSD version difference but otherwise looks good to me! |
I think it's best to merge this as is and I'll try to find some time to add lists for the other targets. For FreeBSD can make lists like |
Seems the TODO in the OP isn't addressed, I'd like to see it in this PR. |
I don't really have the time to add all the lists for the targets any time soon, so it will take a while. |
Ah I mean the second TODO, |
Done. |
Thank you for working on it! |
📌 Commit e864628 has been approved by |
…hnTitor Add regression test infrastructure Please the commit messages for details. I still need to add lists for the following targets, but I got the major ones I think. TODO: * aarch64-unknown-hermit * x86_64-unknown-hermit * x86_64-pc-solaris * x86_64-sun-solaris * sparcv9-sun-solaris * x86_64-fortanix-unknown-sgx * x86_64-unknown-illumos * asmjs-unknown-emscripten * wasm32-unknown-emscripten * wasm32-unknown-unknown * wasm32-wasi * Check symbols added after commit ed45c26. TODO: add a bit to the contributing guide about adding to these lists. Closes #2104.
💔 Test failed - checks-actions |
Looks like the check isn't working well on |
This first step add the infrastructure to test if libc follows semantic versioning. In the build step it creates a test file which imports all functions, constants, etc. that are expected to be public. This file is generated from the files in the (not yet included) semver directory. These files include the function and constants expected to be public per target family, vendor, OS, etc. See the do_semver function in the build file of libc-test for the details.
The failure for arm-linux-androideabi seems unrelated: |
Hmm, but this happens twice (https://github.com/rust-lang/libc/runs/2245677639?check_suite_focus=true) on semver check so I guess we need some work there. |
Looking at Lines 42 to 47 in bd7e052
|
Testing on Android (in ci/runtest-android.rs) seems to depend on the test outputting it was successful.
I can't run it locally so hopefully 418c481 fixes it. |
@bors try |
Add regression test infrastructure Please the commit messages for details. I still need to add lists for the following targets, but I got the major ones I think. TODO: * aarch64-unknown-hermit * x86_64-unknown-hermit * x86_64-pc-solaris * x86_64-sun-solaris * sparcv9-sun-solaris * x86_64-fortanix-unknown-sgx * x86_64-unknown-illumos * asmjs-unknown-emscripten * wasm32-unknown-emscripten * wasm32-unknown-unknown * wasm32-wasi * Check symbols added after commit ed45c26. TODO: add a bit to the contributing guide about adding to these lists. Closes #2104.
☀️ Try build successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Thank you @bors, @JohnTitor CI is green 👍 |
Thanks for working on it! @bors r+ |
📌 Commit 418c481 has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
I have the following error on OpenBSD:
it seems it is because the mentioned symbols are in how to correct it ? move the symbols from |
several symbols added to semver regression tests in "unix" aren't defined on OpenBSD. move these symbols in OS specific files.
several symbols added to semver regression tests in "unix" aren't defined on OpenBSD. move these symbols in OS specific files.
unbreak openbsd after #2109 several symbols added to semver regression tests in "unix" aren't defined on OpenBSD. move these symbols in OS specific files.
unbreak openbsd after #2109 several symbols added to semver regression tests in "unix" aren't defined on OpenBSD. move these symbols in OS specific files.
Sorry for the late response @semarie, but I see you've already fixed the problem, thanks. |
The semver regression checks in rust-lang#2109 included the "SO_REUSEPORT" constant, which we do not yet have on illumos systems. Move it out to platform-specific files.
The semver regression checks in rust-lang#2109 included the "SO_REUSEPORT" constant, which we do not yet have on illumos systems. Move it out to platform-specific files.
The semver regression checks in rust-lang#2109 included the "SO_REUSEPORT" constant, which we do not yet have on illumos systems. Move it out to platform-specific files.
The semver regression checks in rust-lang#2109 included the "SO_REUSEPORT" constant, which we do not yet have on illumos systems. Move it out to platform-specific files.
The semver regression checks in rust-lang#2109 included the "SO_REUSEPORT" constant, which we do not yet have on illumos systems. Move it out to platform-specific files.
Please the commit messages for details.
I still need to add lists for the following targets, but I got the major ones I think.
TODO:
TODO: add a bit to the contributing guide about adding to these lists.
Closes #2104.