-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add struct sock_txtime and related flags #2415
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit a09bc47 has been approved by |
Add struct sock_txtime and related flags These are needed to use the SO_TXTIME socket option on Linux, which is already exposed.
💔 Test failed - checks-actions |
Just realized I didn't add the new things to |
☔ The latest upstream changes (presumably #2403) made this pull request unmergeable. Please resolve the merge conflicts. |
The semver check is unrelated, something on MIPS is different. |
According to https://github.com/rust-lang/libc/blob/master/ci/docker/mips-unknown-linux-musl/Dockerfile#L9, it looks like the mips+musl CI builds use Linux 4.14, but Does this seem reasonable @JohnTitor? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ |
📌 Commit 0fa63b4 has been approved by |
Add struct sock_txtime and related flags These are needed to use the SO_TXTIME socket option on Linux, which is already exposed.
💔 Test failed - checks-actions |
Ugh, that didn't work either. I managed to run the mips+musl build locally, and apparently what is needed is to wrap the struct and consts in a The Semver macOS failure seems unrelated though (master also fails that currently). Hopefully this will work now. Please have a look again when you have time @JohnTitor. |
Thanks for investigating, let's try again :) |
📌 Commit 2c8a498 has been approved by |
Add struct sock_txtime and related flags These are needed to use the SO_TXTIME socket option on Linux, which is already exposed.
💔 Test failed - checks-actions |
These are needed to use the SO_TXTIME socket option on Linux, which is already exposed.
Ok, so, looks like this latest failure was my fault, as I didn't realize I still had to wrap the struct in This should be fixed now, so yet again, hopefully this will work now 🤞 please try again when you geta chance @JohnTitor (and thanks for being patient). |
👍, @bors r+ |
📌 Commit 07e5721 has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Bump version to 0.2.104 I'd like to get #2415 into a release so I can use the new API in a change I'm working on for the `nix` crate, please.
Enable sock_txtime on mips musl target The struct and related constants were originally added in #2415. But they weren't enabled for mips musl target because the kernel version of the build image was old and they couldn't pass the build. Now the kernel version of the build image is already updated and I think we could enable them for mips musl target
Enable sock_txtime on mips musl target The struct and related constants were originally added in #2415. But they weren't enabled for mips musl target because the kernel version of the build image was old and they couldn't pass the build. Now the kernel version of the build image is already updated and I think we could enable them for mips musl target
These are needed to use the SO_TXTIME socket option on Linux, which is
already exposed.