Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes for Linux/m68k #2680

Merged
merged 3 commits into from
Feb 12, 2022
Merged

Build fixes for Linux/m68k #2680

merged 3 commits into from
Feb 12, 2022

Conversation

glaubitz
Copy link
Contributor

This PR contains a few fixes on top of #2414 that were not previously discovered.

I have verified that with these fixes applied, the libc module builds fine on Linux/m68k.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Feb 12, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2022

📌 Commit 7987180 has been approved by Amanieu

bors added a commit that referenced this pull request Feb 12, 2022
Build fixes for Linux/m68k

This PR contains a few fixes on top of #2414 that were not previously discovered.

I have verified that with these fixes applied, the libc module builds fine on Linux/m68k.
@bors
Copy link
Contributor

bors commented Feb 12, 2022

⌛ Testing commit 7987180 with merge cceed45...

@bors
Copy link
Contributor

bors commented Feb 12, 2022

💔 Test failed - checks-actions

@glaubitz
Copy link
Contributor Author

@Amanieu The build failure seems unrelated to these changes:

 Compiling itertools v0.10.3
error[E0658]: use of unstable library feature 'proc_macro_is_available'
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/detection.rs:28:21
   |
28 |     let available = proc_macro::is_available();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #71436 <https://github.com/rust-lang/rust/issues/71436> for more information
   = help: add `#![feature(proc_macro_is_available)]` to the crate attributes to enable

For more information about this error, try `rustc --explain E0658`.
error: could not compile `proc-macro2` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `semverver v0.1.48`, intermediate artifacts can be found at `/tmp/cargo-installLGaK81`

@glaubitz
Copy link
Contributor Author

@Amanieu I just rebased and pushed again. I think we can ask Bors again ;).

@Amanieu
Copy link
Member

Amanieu commented Feb 12, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2022

📌 Commit c63c6a6 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Feb 12, 2022

⌛ Testing commit c63c6a6 with merge 6429755...

@bors
Copy link
Contributor

bors commented Feb 12, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 6429755 to master...

@bors bors merged commit 6429755 into rust-lang:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants