Expose more thread bindings for BSD-like OSes. #2733

iddm · 2022-03-26T12:31:51Z

Fixes #2721

rust-highfive · 2022-03-26T12:31:53Z

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

iddm · 2022-03-26T15:22:33Z

Is there anything I can do to let the Cirrus CI work?

semarie · 2022-03-26T15:48:00Z

src/unix/bsd/netbsdlike/openbsd/mod.rs

+    pub fn sched_setparam(pid: ::pid_t, param: *const sched_param) -> ::c_int;
+    pub fn sched_getparam(pid: ::pid_t, param: *mut sched_param) -> ::c_int;
+    pub fn sched_getscheduler(pid: ::pid_t) -> ::c_int;
+    pub fn sched_setscheduler(pid: ::pid_t, policy: ::c_int, param: *const sched_param) -> ::c_int;


the 4 sched_* functions aren't defined on OpenBSD. In fact, they exists in sched.h but under #if 0. so it will not link.

Oh no! :( Thanks for noticing this. Really love that "not yet" comment there.

I've removed those.

devnexen · 2022-03-27T08:32:41Z

src/unix/bsd/netbsdlike/netbsd/mod.rs

@@ -2405,6 +2405,16 @@ extern "C" {
        size: ::size_t,
        set: *mut cpuset_t,
    ) -> ::c_int;
+    pub fn pthread_setschedparam(


As I implied in your ticket, I suggest to put both these in src/unix/bsd/netbsd/mod.rs so both systems inherit it.

Initially, I did that, but it lead to some errors. Trying once more.

devnexen · 2022-03-27T08:36:00Z

other than that you can fill libc-test/semver/netbsd.txt and libc-test/semver/openbsd.txt lists so they will appear in the docs.

semarie · 2022-03-27T13:13:54Z

src/unix/bsd/netbsdlike/netbsd/mod.rs

-    pub struct sched_param {
-        pub sched_priority: ::c_int,
-    }
-


the struct definition should be moved to src/unix/bsd/netbsdlike/mod.rs , and not just removed.
else it is fine.

Yes, I am sorry, didn't push that.

devnexen · 2022-03-27T15:10:00Z

Looks ok now nice !

Amanieu · 2022-03-27T15:11:32Z

@bors r+

bors · 2022-03-27T15:11:34Z

📌 Commit 4454b97 has been approved by Amanieu

Expose more thread bindings for BSD-like OSes. Fixes #2721

bors · 2022-03-27T15:11:40Z

⌛ Testing commit 4454b97 with merge f6338e3...

bors · 2022-03-27T15:54:31Z

💔 Test failed - checks-actions

iddm · 2022-03-27T17:26:45Z

Current error is:

error[E0658]: use of unstable library feature 'proc_macro_is_available'
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/detection.rs:28:21
   |
28 |     let available = proc_macro::is_available();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #71436 <https://github.com/rust-lang/rust/issues/71436> for more information
   = help: add `#![feature(proc_macro_is_available)]` to the crate attributes to enable

For more information about this error, try `rustc --explain E0658`.
error: could not compile `proc-macro2` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `semverver v0.1.48`, intermediate artifacts can be found at `/tmp/cargo-installzIFZ77`

Caused by:
  build failed
Error: Process completed with exit code 101.

Also, can I push the Cargo.toml version bump?

devnexen · 2022-03-27T17:32:26Z

actual error is this

error[E0412]: cannot find type `sched_param` in this scope
    --> src/unix/bsd/netbsdlike/netbsd/mod.rs:2516:53
     |
2516 |     pub fn sched_getparam(pid: ::pid_t, param: *mut sched_param) -> ::c_int;
     |                                                     ^^^^^^^^^^^ not found in this scope
     |
help: consider importing this struct
     |
2790 |         use sched_param;

iddm · 2022-03-27T20:22:28Z

actual error is this

error[E0412]: cannot find type `sched_param` in this scope
    --> src/unix/bsd/netbsdlike/netbsd/mod.rs:2516:53
     |
2516 |     pub fn sched_getparam(pid: ::pid_t, param: *mut sched_param) -> ::c_int;
     |                                                     ^^^^^^^^^^^ not found in this scope
     |
help: consider importing this struct
     |
2790 |         use sched_param;

Interesting! How were you able to find it? I will fix it if there is just this one error, but I don't know how to actually check if it builds cuz I don't have an openbsd. :(

Amanieu · 2022-03-30T17:45:00Z

Click on the checks-actions link from bors then scroll on the left to find the actual builder that failed. Ignore the semver builders, the result from those is currently ignored.

Amanieu · 2022-04-02T23:14:51Z

@bors r+

bors · 2022-04-02T23:14:52Z

📌 Commit 576f86d has been approved by Amanieu

bors · 2022-04-02T23:14:59Z

⌛ Testing commit 576f86d with merge 02bdb0a...

bors · 2022-04-03T00:17:07Z

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 02bdb0a to master...

iddm · 2022-04-04T11:30:58Z

Thanks everyone.

rust-highfive assigned Amanieu Mar 26, 2022

rust-highfive added the S-waiting-on-review label Mar 26, 2022

iddm force-pushed the add-pthread-functions-to-bsd branch from e580478 to d70b9e4 Compare March 26, 2022 12:35

iddm changed the title ~~Expose more pthread bindings for BSD-like OSes.~~ WIP: Expose more pthread bindings for BSD-like OSes. Mar 26, 2022

iddm force-pushed the add-pthread-functions-to-bsd branch 10 times, most recently from c6d150d to 0254cec Compare March 26, 2022 14:58

iddm changed the title ~~WIP: Expose more pthread bindings for BSD-like OSes.~~ Expose more thread bindings for BSD-like OSes. Mar 26, 2022

iddm force-pushed the add-pthread-functions-to-bsd branch 2 times, most recently from e82fed7 to 838e439 Compare March 26, 2022 15:23

semarie suggested changes Mar 26, 2022

View reviewed changes

iddm force-pushed the add-pthread-functions-to-bsd branch from 838e439 to bb5bfc2 Compare March 26, 2022 20:03

devnexen reviewed Mar 27, 2022

View reviewed changes

iddm force-pushed the add-pthread-functions-to-bsd branch 2 times, most recently from 7ad58ca to e3fc344 Compare March 27, 2022 12:59

semarie reviewed Mar 27, 2022

View reviewed changes

iddm force-pushed the add-pthread-functions-to-bsd branch from e3fc344 to 4454b97 Compare March 27, 2022 14:51

bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 27, 2022

bors added a commit that referenced this pull request Mar 27, 2022

Auto merge of #2733 - vityafx:add-pthread-functions-to-bsd, r=Amanieu

f6338e3

Expose more thread bindings for BSD-like OSes. Fixes #2721

bors added S-waiting-on-review and removed S-waiting-on-bors labels Mar 27, 2022

Expose more thread bindings for NetBSD-like OSes.

576f86d

iddm force-pushed the add-pthread-functions-to-bsd branch from 4454b97 to 576f86d Compare April 1, 2022 15:21

bors added S-waiting-on-bors and removed S-waiting-on-review labels Apr 2, 2022

bors merged commit 02bdb0a into rust-lang:master Apr 3, 2022

iddm deleted the add-pthread-functions-to-bsd branch April 4, 2022 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose more thread bindings for BSD-like OSes. #2733

Expose more thread bindings for BSD-like OSes. #2733

iddm commented Mar 26, 2022 •

edited

Loading

rust-highfive commented Mar 26, 2022

iddm commented Mar 26, 2022

semarie Mar 26, 2022

iddm Mar 26, 2022

iddm Mar 27, 2022

devnexen Mar 27, 2022

iddm Mar 27, 2022

devnexen commented Mar 27, 2022

semarie Mar 27, 2022

iddm Mar 27, 2022

devnexen commented Mar 27, 2022

Amanieu commented Mar 27, 2022

bors commented Mar 27, 2022

bors commented Mar 27, 2022

bors commented Mar 27, 2022

iddm commented Mar 27, 2022 •

edited

Loading

devnexen commented Mar 27, 2022 •

edited

Loading

iddm commented Mar 27, 2022

Amanieu commented Mar 30, 2022

Amanieu commented Apr 2, 2022

bors commented Apr 2, 2022

bors commented Apr 2, 2022

bors commented Apr 3, 2022

iddm commented Apr 4, 2022

Expose more thread bindings for BSD-like OSes. #2733

Expose more thread bindings for BSD-like OSes. #2733

Conversation

iddm commented Mar 26, 2022 • edited Loading

rust-highfive commented Mar 26, 2022

iddm commented Mar 26, 2022

semarie Mar 26, 2022

Choose a reason for hiding this comment

iddm Mar 26, 2022

Choose a reason for hiding this comment

iddm Mar 27, 2022

Choose a reason for hiding this comment

devnexen Mar 27, 2022

Choose a reason for hiding this comment

iddm Mar 27, 2022

Choose a reason for hiding this comment

devnexen commented Mar 27, 2022

semarie Mar 27, 2022

Choose a reason for hiding this comment

iddm Mar 27, 2022

Choose a reason for hiding this comment

devnexen commented Mar 27, 2022

Amanieu commented Mar 27, 2022

bors commented Mar 27, 2022

bors commented Mar 27, 2022

bors commented Mar 27, 2022

iddm commented Mar 27, 2022 • edited Loading

devnexen commented Mar 27, 2022 • edited Loading

iddm commented Mar 27, 2022

Amanieu commented Mar 30, 2022

Amanieu commented Apr 2, 2022

bors commented Apr 2, 2022

bors commented Apr 2, 2022

bors commented Apr 3, 2022

iddm commented Apr 4, 2022

iddm commented Mar 26, 2022 •

edited

Loading

iddm commented Mar 27, 2022 •

edited

Loading

devnexen commented Mar 27, 2022 •

edited

Loading