-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android uinput bindings #2984
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. |
Currently, our CI for Android has been disabled and I'd like to fix it before approving this PR, sorry for the inconvenience! |
For what it's worth, I think there might be something wrong with the Android build anyway. I had to comment out these lines in linux_like/android/mod.rs in order to get the tests to run. NDK 21.4.7075529.
Errors from libc-test:
よろしくお願いします |
Hmm, I guess your setup is different from our CI's? These consts are old enough and I don't think it makes difference. Anyway, x86_64 CI has been fixed, so let's go ahead. Thanks for the PR! |
@bors r+ |
Add Android uinput bindings This is mostly copied from the Linux bindings.
💔 Test failed - checks-actions |
6ad0fd0
to
b1b6350
Compare
Corrected |
@bors r+ |
Add Android uinput bindings This is mostly copied from the Linux bindings.
💔 Test failed - checks-actions |
b1b6350
to
6dbe488
Compare
Added missing traits |
Thanks! @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This is mostly copied from the Linux bindings.