Add Trusty platform support #2987
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. |
|
For maintenance reasons, I'd like to add target support when it's official (the official targets have target maintainers and we could ensure whether a target is still active or not). At a glance, there's no Trusty-related target on rust-lang/rust repo, could you propose adding it there first? |
|
I've put up a PR to add the trusty compilation targets: rust-lang/rust#103895 Is that enough to move this PR forward? Or did you want to wait until the new targets are approved in the main Rust project before merging here? Because that PR depends on the new APIs added in this PR, which compilates things 😅 |
| } else if #[cfg(target_os = "trusty")] { | ||
| mod fixed_width_ints; | ||
| pub use fixed_width_ints::*; | ||
|
|
||
| mod trusty; | ||
| pub use trusty::*; |
There was a problem hiding this comment.
I wonder if we could move the module under linux_like or somewhere else similar to that. I'm not familiar with Trusty but is it completely different from Linux-like OS (i.e. exposing linux-like items on Trusty is harmful)?
|
I see rust-lang/compiler-team#582 is approved and it's a good time to go ahead. |
|
Closing as inactive, feel free to resolve the above comment and re-submit a PR if you're still interested in this change. Thanks for your contribution anyway! |
This PR adds support for the Trusty secure operating system. This upstreams the patch that we have been using internally, cleaned up to meet the project's style conventions.