Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: add rtnetlink ifinfomsg attribute enumerals #3051

Merged
merged 1 commit into from
May 6, 2023
Merged

linux: add rtnetlink ifinfomsg attribute enumerals #3051

merged 1 commit into from
May 6, 2023

Conversation

tones111
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@tones111 tones111 mentioned this pull request Dec 26, 2022
Closed
@tones111
Copy link
Contributor Author

Updated to use c_int.

The kernel declares these symbols within enums (if.h) without specifying specific values, so it seems unlikely they'll exceed u8::MAX. I think the compiler has some liberty to determine the underlying size of integer to use, but c_int is more consistent with the other symbols in this file.

Thanks for the review

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Jan 18, 2023

📌 Commit 22e6b1c has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 18, 2023

⌛ Testing commit 22e6b1c with merge 44cfc0e...

bors added a commit that referenced this pull request Jan 18, 2023
@bors
Auto merge of #3051 - tones111:rtnl_if_enum, r=JohnTitor
44cfc0e 
linux: add rtnetlink ifinfomsg attribute enumerals
@bors
Copy link
Contributor

bors commented Jan 18, 2023

💥 Test timed out

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Jan 28, 2023

⌛ Testing commit 22e6b1c with merge 155478c...

bors added a commit that referenced this pull request Jan 28, 2023
@bors
Auto merge of #3051 - tones111:rtnl_if_enum, r=JohnTitor
155478c 
linux: add rtnetlink ifinfomsg attribute enumerals
@bors
Copy link
Contributor

bors commented Jan 28, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2023

📌 Commit bfc1543 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 3, 2023

⌛ Testing commit bfc1543 with merge df05201...

bors added a commit that referenced this pull request Feb 3, 2023
@bors
Auto merge of #3051 - tones111:rtnl_if_enum, r=JohnTitor
df05201 
linux: add rtnetlink ifinfomsg attribute enumerals
@bors
Copy link
Contributor

bors commented Feb 3, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

Some items need to be excluded on sparc64 test.

@tones111
Copy link
Contributor Author

Thank goodness for CI. I Think we've finally got this pull request through the checks. Thanks for your help.

@JohnTitor
Copy link
Member

👍 @bors r+

@bors
Copy link
Contributor

bors commented Apr 23, 2023

📌 Commit 1abdc61 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 23, 2023

⌛ Testing commit 1abdc61 with merge 78cfe04...

bors added a commit that referenced this pull request Apr 23, 2023
@bors
Auto merge of #3051 - tones111:rtnl_if_enum, r=JohnTitor
78cfe04 
linux: add rtnetlink ifinfomsg attribute enumerals
@bors
Copy link
Contributor

bors commented Apr 23, 2023

💔 Test failed - checks-actions

@tones111
Copy link
Contributor Author

It looks like the sparc64 target is still failing, but I can't tell from the logs what's wrong. Do you have any suggestions?

@JohnTitor
Copy link
Member

It's a timeout failure, so @bors retry

@bors
Copy link
Contributor

bors commented May 6, 2023

⌛ Testing commit 1abdc61 with merge a11d63a...

@bors
Copy link
Contributor

bors commented May 6, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing a11d63a to master...

@bors bors merged commit a11d63a into rust-lang:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tones111 @rustbot @JohnTitor @bors