-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux/uclibc: resync syscall tables #3061
Conversation
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
@@ -884,11 +884,34 @@ pub const SYS_pwritev2: ::c_long = 393; | |||
pub const SYS_pkey_mprotect: ::c_long = 394; | |||
pub const SYS_pkey_alloc: ::c_long = 395; | |||
pub const SYS_pkey_free: ::c_long = 396; | |||
pub const SYS_statx: ::c_int = 397; | |||
pub const SYS_statx: ::c_long = 397; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: I think this was a buggy definition, probably a copy-paste mistake that slipped in through #2403.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a FIXME instead of changing its type? it was added in 2021 and I guess it could break some code 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, changed.
16f3cc7
to
5d7953d
Compare
@JohnTitor ping, may I get this reviewed/merged? |
Sorry for the delay, I've been a bit busy/tired. Left one comment, otherwise LGTM 👍 |
This adds some missing syscall constants for uclibc on `arm` and `mips32`. The two syscall tables are now again in sync with the musl ones that they are based on.
5d7953d
to
798eeeb
Compare
Thanks! @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
1 similar comment
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
This adds some missing syscall constants for uclibc on
arm
andmips32
. The two syscall tables are now again in sync with the musl ones that they are based on.