Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testing of primitive types from std #3616

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

ChrisDenton
Copy link
Member

std shouldn't need to depend on libc for platforms that don't require it, but currently one test means it is required.

It was suggested that this test more properly belongs in the libc crate itself, so I've made this PR for your consideration.

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added this pull request to the merge queue Aug 12, 2024
@ChrisDenton ChrisDenton removed this pull request from the merge queue due to a manual request Aug 12, 2024
@ChrisDenton
Copy link
Member Author

Oh wait I just noticed an issue. This needs to be added to the libc-test Cargo.toml otherwise it's not actually being run.

@tgross35
Copy link
Contributor

Wow that is deceptive. We should just use tests/ for everything that doesn't need to disable the harness, then put the no-harness tests somewhere else.

@ChrisDenton
Copy link
Member Author

Yeah, that sounds like a good idea. I only noticed because I looked at it in my editor and it helpfully greyed out the code. I couldn't immediately figure out why so I investigated further.

@ChrisDenton ChrisDenton added this pull request to the merge queue Aug 12, 2024
Merged via the queue into rust-lang:main with commit c8cc152 Aug 12, 2024
39 checks passed
@ChrisDenton ChrisDenton deleted the primitive branch August 12, 2024 12:47
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 17, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 18, 2024
(backport <rust-lang#3616>)
(cherry picked from commit d4da6c8)
@tgross35 tgross35 mentioned this pull request Nov 18, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants