-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move testing of primitive types from std #3616
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use r? to explicitly pick a reviewer |
Oh wait I just noticed an issue. This needs to be added to the libc-test Cargo.toml otherwise it's not actually being run. |
Wow that is deceptive. We should just use |
Yeah, that sounds like a good idea. I only noticed because I looked at it in my editor and it helpfully greyed out the code. I couldn't immediately figure out why so I investigated further. |
(backport <rust-lang#3616>) (cherry picked from commit d4da6c8)
std shouldn't need to depend on libc for platforms that don't require it, but currently one test means it is required.
It was suggested that this test more properly belongs in the libc crate itself, so I've made this PR for your consideration.