Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set type of POSIX_SPAWN_* flags to c_short #3629

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

samueltardieu
Copy link
Contributor

Changing the type from c_int to c_short will likely not break existing programs. It might introduce warnings about no-longer needed conversions to c_short though.

Fixes #3627

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2024

Some changes occurred in OpenBSD module

cc @semarie

@samueltardieu
Copy link
Contributor Author

Docker failure is unrelated

Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for OpenBSD. thanks.

Changing the type from `c_int` to `c_short` will likely not break existing
programs. It might introduce warnings about no-longer needed
conversions to `c_short` though.
@JohnTitor JohnTitor added this pull request to the merge queue Apr 29, 2024
Merged via the queue into rust-lang:main with commit e6673b0 Apr 29, 2024
41 checks passed
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 17, 2024
These were changed in f62eb02 ("Set type of POSIX_SPAWN_* flags to
c_short"). PR: <rust-lang#3629>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POSIX_SPAWN_* flags have incorrect type
5 participants