Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

illumos: expose PIPE_BUF constant #3633

Merged
merged 1 commit into from
Apr 26, 2024
Merged

illumos: expose PIPE_BUF constant #3633

merged 1 commit into from
Apr 26, 2024

Conversation

dancrossnyc
Copy link
Contributor

Expose the PIPE_BUF constant on Solaris/illumos. We have verified that these values are the same between the two variants of the system.

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@jclulow
Copy link
Contributor

jclulow commented Mar 26, 2024

What are you planning to use this constant for?

@labbott
Copy link

labbott commented Mar 26, 2024

What are you planning to use this constant for?

This is needed to get tokio-pipe to build https://github.com/yskszk63/tokio-pipe/blob/master/src/lib.rs#L40

@jclulow
Copy link
Contributor

jclulow commented Mar 26, 2024

Alright that makes sense, thanks.

@dancrossnyc
Copy link
Contributor Author

dancrossnyc commented Apr 25, 2024 •
edited
Loading

Ping? (@JohnTitor)

@JohnTitor
Copy link
Member

Sorry for the delay, thanks for the PR!

@JohnTitor JohnTitor added this pull request to the merge queue Apr 26, 2024
Merged via the queue into rust-lang:main with commit b1270be Apr 26, 2024
41 checks passed
@dancrossnyc
Copy link
Contributor Author

Thank you!

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 13, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 13, 2024
@dancrossnyc @tgross35
illumos: expose PIPE_BUF constant
6f6593c 
(backport <rust-lang#3633>)
(cherry picked from commit 64d8a2f)
@tgross35 tgross35 mentioned this pull request Aug 13, 2024
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 13, 2024
@dancrossnyc @tgross35
illumos: expose PIPE_BUF constant
b63b626 
(backport <rust-lang#3633>)
(cherry picked from commit 64d8a2f)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@pfmooney pfmooney pfmooney approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dancrossnyc @rustbot @jclulow @labbott @JohnTitor @pfmooney @tgross35