Remove extra traits

[rj00a]

This PR removes the extra_traits feature and all implementations of Eq, Hash, and Debug as mentioned in #3248.

The decision to remove Debug impls was left as an open question, but I've gone ahead and removed them here in the interest of maintainability and consistency.

Closes #2700, #2064, #2816

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rustbot]

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Some changes occurred in OpenBSD module

cc @semarie

[rj00a]

I had to allow multiple s! macros in one module because the s_no_extra_traits! macro no longer exists.

[bors]

☔ The latest upstream changes (presumably #3617) made this pull request unmergeable. Please resolve the merge conflicts.

[myl7]

Hi, I am the one who is working on the project to modernize the libc crate (Related: OSPP Idea OSPP Zulip).
I would like to ask that if I could rebase your commits and develop upon them, to complete the "trait implementations" change for libc v1?

[SteveLauC]

I would like to ask that if I could rebase your commits and develop upon them, to complete the "trait implementations" change for libc v1?

Hi, would you like to show me what these trait impl would look like in libc 1.0, this is not covered in the tracking issue and that OSPP page. Nix, as a big consumer of the libc crate, uses them a lot: nix-rust/nix#2468

[erickt]

As an alternative to getting rid of extra_traits, another direction could be to use or build a library like zerocopy to assert at compile time that all the fields of a union can be referenced without UB? That could be done through a test-only cfg to reduce compile times, or if the MSRV didn't support this or something.

[myl7]

what these trait impl would look like in libc 1.0

According to the "Trait implementations" section, I think Eq and Hash impl would be completely removed.
Debug impl may be kept, but at least future code would not impl it.

[tgross35]

Hey @myl7: we still need to figure out what exactly we want to do with traits here (at this point I'm thinking we should keep Debug but remove the rest, but that hasn't been discussed), but any chance you would want to pick up #4118? That is something we could merge today, and would make the diff here a bit smaller once we have a final decision.

[tgross35]

@rj00a are you able to finish this up? If so, please drop PartialEq, Eq, and Hash but leave Debug.

@rustbot author